Skip to content

feat(ci): opt-in e2e-report-path input to keep the e2e (Playwright) report - #75

Merged
ghostkernel-core merged 1 commit into
masterfrom
ci-e2e-report-artifact
Oct 30, 2026
Merged

ghostkernel-core merged 1 commit into
masterfrom
ci-e2e-report-artifact

Conversation

@ghostkernel-core

Copy link
Copy Markdown
Contributor

What

This PR adds a new generic input, e2e-report-path, to the reusable ci.yml. It follows the same pattern as the earlier build-args, exclude-paths and ruff-version inputs.

  • Type and default: string, default ''.
  • When set: the e2e job gets one more step after "Run E2E tests":
    - name: Upload E2E report
      if: always() && inputs.e2e-report-path != ''
      uses: actions/upload-artifact@v7
      continue-on-error: true
      with:
        name: e2e-report-${{ github.run_id }}-${{ github.run_attempt }}
        path: ${{ inputs.e2e-report-path }}
        retention-days: 7
        if-no-files-found: ignore
  • Path: resolved from the repo root, not from e2e-working-dir. working-directory only applies to run steps, never to a uses: step. The input description and its comment say so.
  • Failure handling: the step runs on always() because the failed run is the one worth inspecting. It uses continue-on-error, so an upload failure can't turn a green e2e job red. This is the same reasoning as the existing security-reports-* upload.
  • Pinning: it uses @v7, the same as the file's other upload-artifact steps.

Default is off

With the empty default, the step's if: is false for every existing caller, so nothing changes for them.

  • No new required input.
  • No permission changes.
  • No other workflow changes.

Why

CognitiveSystems WP-61 (UI visual and accessibility QA) attaches per-route screenshots to the Playwright HTML report for human review. Its Acceptance 13 needs that report kept as a CI artifact. Today the shared e2e job throws it away.

After merge (human steps)

  • The v1 tag: merging to master ships nothing to consumers. A human must advance the v1 tag afterwards; it is not done or prepared here. The v1..master diff on ci.yml is currently comment-only (e7907b8, stale ARCRunner references), so advancing v1 would carry only that plus this change in ci.yml. The other files in v1..master should be reviewed separately.
  • Consumer follow-up: once v1 ships, a separate CognitiveSystems PR adds e2e-report-path: frontend/playwright-report to its thin ci.yml wrapper.

Validation

All of the following were run locally:

  • actionlint 1.7.7 on ci.yml: clean. The release checksum was verified, and the result was also clean before the change.
  • yamllint (repo .yamllint): no new findings. The two existing line-length warnings and the CRLF findings from the Windows checkout are the same before and after.
  • PyYAML parse: the new input and step resolve as intended.
  • python -m pytest tests -q: 25 passed.
  • git diff --check: clean.

self-ci.yml pins ci.yml@v1, so this PR's own CI does not exercise the new step.

🤖 Generated with Claude Code

New generic input `e2e-report-path` (string, default ''). When set, the
e2e job uploads that path (relative to the repo root) as artifact
e2e-report-<run_id>-<run_attempt> on always(), continue-on-error, 7-day
retention, if-no-files-found: ignore. Empty default adds no step for any
existing caller.

Requested by CognitiveSystems WP-61 (keep the Playwright HTML report).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ghostkernel-core
ghostkernel-core merged commit 60f55f4 into master Oct 30, 2026
17 checks passed
@ghostkernel-core
ghostkernel-core deleted the ci-e2e-report-artifact branch October 30, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant