Repository navigation
feat(ci): opt-in e2e-report-path input to keep the e2e (Playwright) report - #75
Merged
Merged
Conversation
New generic input `e2e-report-path` (string, default ''). When set, the e2e job uploads that path (relative to the repo root) as artifact e2e-report-<run_id>-<run_attempt> on always(), continue-on-error, 7-day retention, if-no-files-found: ignore. Empty default adds no step for any existing caller. Requested by CognitiveSystems WP-61 (keep the Playwright HTML report). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR adds a new generic input,
e2e-report-path, to the reusableci.yml. It follows the same pattern as the earlierbuild-args,exclude-pathsandruff-versioninputs.''.e2ejob gets one more step after "Run E2E tests":e2e-working-dir.working-directoryonly applies torunsteps, never to auses:step. The input description and its comment say so.always()because the failed run is the one worth inspecting. It usescontinue-on-error, so an upload failure can't turn a green e2e job red. This is the same reasoning as the existingsecurity-reports-*upload.@v7, the same as the file's otherupload-artifactsteps.Default is off
With the empty default, the step's
if:is false for every existing caller, so nothing changes for them.Why
CognitiveSystems WP-61 (UI visual and accessibility QA) attaches per-route screenshots to the Playwright HTML report for human review. Its Acceptance 13 needs that report kept as a CI artifact. Today the shared
e2ejob throws it away.After merge (human steps)
v1tag: merging tomasterships nothing to consumers. A human must advance thev1tag afterwards; it is not done or prepared here. Thev1..masterdiff onci.ymlis currently comment-only (e7907b8, stale ARCRunner references), so advancingv1would carry only that plus this change inci.yml. The other files inv1..mastershould be reviewed separately.v1ships, a separate CognitiveSystems PR addse2e-report-path: frontend/playwright-reportto its thinci.ymlwrapper.Validation
All of the following were run locally:
ci.yml: clean. The release checksum was verified, and the result was also clean before the change..yamllint): no new findings. The two existing line-length warnings and the CRLF findings from the Windows checkout are the same before and after.python -m pytest tests -q: 25 passed.git diff --check: clean.self-ci.ymlpinsci.yml@v1, so this PR's own CI does not exercise the new step.🤖 Generated with Claude Code